Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and reversal of some features. #774

Merged
merged 16 commits into from
Oct 15, 2024
Merged

Fixes and reversal of some features. #774

merged 16 commits into from
Oct 15, 2024

Conversation

Vladik01-11
Copy link
Contributor

  • Fixing CJ's shadow
  • Corrects sun shadow movement
  • Reverse some functions

@Vladik01-11
Fixes and reversal of some features.
0c0fc89 
* Fixing CJ's shadow
* Corrects sun shadow movement
* Reverse some functions
yukani
yukani reviewed Sep 16, 2024
View reviewed changes
source/game_sa/CarEnterExit.cpp Show resolved Hide resolved
source/game_sa/Entity/Vehicle/Vehicle.cpp Outdated Show resolved Hide resolved
source/game_sa/StencilShadows.cpp Outdated Show resolved Hide resolved
source/game_sa/StencilShadows.cpp Outdated Show resolved Hide resolved
source/game_sa/Game.cpp Outdated Show resolved Hide resolved
Pirulax
Pirulax reviewed Sep 16, 2024
View reviewed changes
source/game_sa/CarEnterExit.cpp Show resolved Hide resolved
source/game_sa/CarEnterExit.cpp Outdated Show resolved Hide resolved
source/game_sa/CarEnterExit.cpp Show resolved Hide resolved
source/game_sa/Entity/Vehicle/Vehicle.cpp Outdated Show resolved Hide resolved
source/game_sa/Entity/Vehicle/Vehicle.cpp Outdated Show resolved Hide resolved
source/game_sa/StencilShadows.cpp Outdated Show resolved Hide resolved
source/game_sa/StencilShadows.cpp Outdated Show resolved Hide resolved
source/game_sa/StencilShadows.cpp Outdated Show resolved Hide resolved
source/game_sa/StencilShadows.h Outdated Show resolved Hide resolved
source/game_sa/StencilShadows.h Show resolved Hide resolved
Pirulax
Pirulax reviewed Sep 18, 2024
View reviewed changes
source/game_sa/CarEnterExit.cpp Outdated Show resolved Hide resolved
source/game_sa/CarEnterExit.cpp Outdated Show resolved Hide resolved
source/game_sa/CarEnterExit.cpp Outdated Show resolved Hide resolved
source/game_sa/CarEnterExit.cpp Outdated Show resolved Hide resolved
source/game_sa/CarEnterExit.cpp Show resolved Hide resolved
source/game_sa/CarEnterExit.cpp Show resolved Hide resolved
source/game_sa/CarEnterExit.cpp Outdated Show resolved Hide resolved
source/game_sa/CarEnterExit.cpp Outdated Show resolved Hide resolved
Pirulax
Pirulax reviewed Sep 21, 2024
View reviewed changes
Copy link
Collaborator

@Pirulax Pirulax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've resolved my comments, but haven't actually fixed it in the code.
Perhaps you haven't pushed the commit?

source/game_sa/CarEnterExit.cpp Outdated Show resolved Hide resolved
@Vladik01-11
Copy link
Contributor Author

ready for retrieval after rechecking

yukani
yukani approved these changes Sep 24, 2024
View reviewed changes
source/game_sa/StencilShadows.h Outdated Show resolved Hide resolved
Pirulax
Pirulax approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@Pirulax Pirulax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok

Pirulax
Pirulax reviewed Sep 24, 2024
View reviewed changes
source/game_sa/Entity/Vehicle/Vehicle.cpp Outdated Show resolved Hide resolved
source/game_sa/Entity/Vehicle/Vehicle.cpp Outdated Show resolved Hide resolved
source/game_sa/Entity/Vehicle/Vehicle.cpp Outdated Show resolved Hide resolved
source/game_sa/Entity/Vehicle/Vehicle.cpp Outdated Show resolved Hide resolved
source/game_sa/Entity/Vehicle/Vehicle.cpp Outdated Show resolved Hide resolved
source/game_sa/Entity/Vehicle/Vehicle.cpp Outdated Show resolved Hide resolved
@Pirulax
Copy link
Collaborator

Pirulax commented Oct 4, 2024

Okay I'll soon (hopefully) resolve the remaining convos, test and then commit the PR

@Vladik01-11
Copy link
Contributor Author

Now you can do whatever you want with PR.

@Pirulax
Copy link
Collaborator

Pirulax commented Oct 6, 2024

Needs testing

@Pirulax Pirulax added the untested Needs basic testing label Oct 6, 2024
@Vladik01-11
Copy link
Contributor Author

  • Fixes NOTSA_UNREACHABLE function name output, thanks @yukani
  • Restore CColStore::FindColSlot
  • Fix garage door height in CObject::ProcessGarageDoorBehaviour
  • Fixes CMenuSystem::Display

@Vladik01-11
Copy link
Contributor Author

The game has been tested.

@Pirulax Pirulax merged commit 20e0965 into gta-reversed:master Oct 15, 2024
3 checks passed
@Pirulax Pirulax mentioned this pull request Oct 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yukani yukani yukani approved these changes

@Pirulax Pirulax Pirulax approved these changes

Assignees
No one assigned
Labels
untested Needs basic testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vladik01-11 @Pirulax @yukani