Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] into_glib_ptr does not need to be unsafe fn #1483

Open
kawadakk opened this issue Aug 21, 2024 · 1 comment
Open

[BUG] into_glib_ptr does not need to be unsafe fn #1483

kawadakk opened this issue Aug 21, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@kawadakk
Copy link
Contributor

Bug description

Similarly to Box::into_raw, IntoGlibPtr::into_glib_ptr merely converts self into a raw pointer, which is inert by itself. There don't seem to be any safety invariants (preconditions) the caller needs to uphold.

Backtrace

N/A
@kawadakk kawadakk added the bug Something isn't working label Aug 21, 2024
@sdroege
Copy link
Member

sdroege commented Aug 21, 2024

That's true, same for to_glib_none() etc.

Do you want to provide a PR for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sdroege @kawadakk