Test failures with rspec 3

[felixonmars]

Hi. We are getting some test failures when packaging notiffany for Arch Linux. Some of them look like related to rspec 3, but I am not sure.

Failures:

  1) Notiffany::Notifier::TerminalNotifier#notify should allow the title to be customized
     Failure/Error: ::TerminalNotifier::Guard.execute(false, opts)

       #<Double (anonymous)> received :execute with unexpected arguments
         expected: (false, {:message=>"any message", :title=>"any title", :type=>:error})
              got: (false, {:message=>"any message", :title=>"any title", :type=>:error})
     # ./lib/notiffany/notifier/terminal_notifier.rb:55:in `_perform_notify'
     # ./lib/notiffany/notifier/base.rb:72:in `notify'
     # ./spec/lib/notiffany/notifier/terminal_notifier_spec.rb:74:in `block (3 levels) in <module:Notiffany>'

  2) Notiffany::Notifier::TerminalNotifier#notify should call the notifier.
     Failure/Error: ::TerminalNotifier::Guard.execute(false, opts)

       #<Double (anonymous)> received :execute with unexpected arguments
         expected: (false, {:message=>"any message", :title=>"any title", :type=>:success})
              got: (false, {:message=>"any message", :title=>"any title", :type=>:success})
     # ./lib/notiffany/notifier/terminal_notifier.rb:55:in `_perform_notify'
     # ./lib/notiffany/notifier/base.rb:72:in `notify'
     # ./spec/lib/notiffany/notifier/terminal_notifier_spec.rb:64:in `block (3 levels) in <module:Notiffany>'

  3) Notiffany::Notifier::TerminalNotifier#notify without a title set should show the app name in the title
     Failure/Error: ::TerminalNotifier::Guard.execute(false, opts)

       #<Double (anonymous)> received :execute with unexpected arguments
         expected: (false, {:message=>"any message", :title=>"FooBar Success", :type=>:success})
              got: (false, {:message=>"any message", :title=>"FooBar Success", :type=>:success})
     # ./lib/notiffany/notifier/terminal_notifier.rb:55:in `_perform_notify'
     # ./lib/notiffany/notifier/base.rb:72:in `notify'
     # ./spec/lib/notiffany/notifier/terminal_notifier_spec.rb:87:in `block (4 levels) in <module:Notiffany>'

  4) Notiffany::Notifier::TerminalNotifier#notify with options passed at initialization uses these options by default
     Failure/Error: ::TerminalNotifier::Guard.execute(false, opts)

       #<Double (anonymous)> received :execute with unexpected arguments
         expected: (false, {:message=>"any message", :title=>"Hello", :type=>:success})
              got: (false, {:message=>"any message", :title=>"Hello", :type=>:success})
     # ./lib/notiffany/notifier/terminal_notifier.rb:55:in `_perform_notify'
     # ./lib/notiffany/notifier/base.rb:72:in `notify'
     # ./spec/lib/notiffany/notifier/terminal_notifier_spec.rb:42:in `block (4 levels) in <module:Notiffany>'

  5) Notiffany::Notifier::TerminalNotifier#notify with options passed at initialization overwrites object options with passed options
     Failure/Error: ::TerminalNotifier::Guard.execute(false, opts)

       #<Double (anonymous)> received :execute with unexpected arguments
         expected: (false, {:message=>"any message", :title=>"Welcome", :type=>:success})
              got: (false, {:message=>"any message", :title=>"Welcome", :type=>:success})
     # ./lib/notiffany/notifier/terminal_notifier.rb:55:in `_perform_notify'
     # ./lib/notiffany/notifier/base.rb:72:in `notify'
     # ./spec/lib/notiffany/notifier/terminal_notifier_spec.rb:53:in `block (4 levels) in <module:Notiffany>'

  6) Notiffany::Notifier::Detected#add with manually configured notifiers when not available does not add the library
     Failure/Error: klass.new(opts) # raises if unavailable

       #<Double "foo_mod"> received :new with unexpected arguments
         expected: ({:foo=>:bar})
              got: ({:foo=>:bar})
        Please stub a default value first if message might be received with other args as well.
     # ./lib/notiffany/notifier/detected.rb:100:in `_add'
     # ./lib/notiffany/notifier/detected.rb:83:in `add'
     # ./spec/lib/notiffany/notifier/detected_spec.rb:105:in `block (5 levels) in <class:Notifier>'

  7) Notiffany::Notifier::Detected#add with manually configured notifiers when not available does not raise an error
     Failure/Error: expect { subject.add(:foo, foo: :bar) }.to_not raise_error

       expected no Exception, got #<RSpec::Mocks::MockExpectationError: #<Double "foo_mod"> received :new with unexpected arguments
         e...=>:bar})
        Please stub a default value first if message might be received with other args as well.
       > with backtrace:
         # ./lib/notiffany/notifier/detected.rb:100:in `_add'
         # ./lib/notiffany/notifier/detected.rb:83:in `add'
         # ./spec/lib/notiffany/notifier/detected_spec.rb:109:in `block (6 levels) in <class:Notifier>'
         # ./spec/lib/notiffany/notifier/detected_spec.rb:109:in `block (5 levels) in <class:Notifier>'
     # ./spec/lib/notiffany/notifier/detected_spec.rb:109:in `block (5 levels) in <class:Notifier>'

  8) Notiffany::Notifier::Detected#add with manually configured notifiers when not available shows a warning
     Failure/Error: klass.new(opts) # raises if unavailable

       #<Double "foo_mod"> received :new with unexpected arguments
         expected: ({:foo=>:bar})
              got: ({:foo=>:bar})
        Please stub a default value first if message might be received with other args as well.
     # ./lib/notiffany/notifier/detected.rb:100:in `_add'
     # ./lib/notiffany/notifier/detected.rb:83:in `add'
     # ./spec/lib/notiffany/notifier/detected_spec.rb:115:in `block (5 levels) in <class:Notifier>'

  9) Notiffany::Notifier::Notifu#notify with additional options can override the default options
     Failure/Error: ::Notifu.show(options) {}

       #<Double (anonymous)> received :show with unexpected arguments
         expected: ({:baloon=>true, :icon=>true, :image=>"/tmp/wait.png", :message=>"Waiting for something", :noquiet=>true, :nosound=>true, :time=>5, :title=>"Waiting", :type=>:warn, :xp=>true})
              got: ({:baloon=>true, :icon=>true, :image=>"/tmp/wait.png", :message=>"Waiting for something", :noquiet=>true, :nosound=>true, :time=>5, :title=>"Waiting", :type=>:warn, :xp=>true})
     # ./lib/notiffany/notifier/rb_notifu.rb:68:in `_perform_notify'
     # ./lib/notiffany/notifier/base.rb:72:in `notify'
     # ./spec/lib/notiffany/notifier/rb_notifu_spec.rb:115:in `block (4 levels) in <class:Notifier>'

  10) Notiffany::Notifier::Notifu#notify without additional options shows the notification with the default options
      Failure/Error: ::Notifu.show(options) {}

        #<Double (anonymous)> received :show with unexpected arguments
          expected: ({:baloon=>false, :icon=>false, :image=>"/tmp/welcome.png", :message=>"Welcome to Guard", :noquiet=>false, :nosound=>false, :time=>3, :title=>"Welcome", :type=>:info, :xp=>false})
               got: ({:baloon=>false, :icon=>false, :image=>"/tmp/welcome.png", :message=>"Welcome to Guard", :noquiet=>false, :nosound=>false, :time=>3, :title=>"Welcome", :type=>:info, :xp=>false})
      # ./lib/notiffany/notifier/rb_notifu.rb:68:in `_perform_notify'
      # ./lib/notiffany/notifier/base.rb:72:in `notify'
      # ./spec/lib/notiffany/notifier/rb_notifu_spec.rb:94:in `block (4 levels) in <class:Notifier>'

  11) Notiffany::Notifier::Notifu#notify with options passed at initialization uses these options by default
      Failure/Error: ::Notifu.show(options) {}

        #<Double (anonymous)> received :show with unexpected arguments
          expected: ({:baloon=>false, :icon=>false, :image=>"/tmp/welcome.png", :message=>"Welcome to Guard", :noquiet=>false, :nosound=>false, :time=>3, :title=>"Hello", :type=>:info, :xp=>false})
               got: ({:baloon=>false, :icon=>false, :image=>"/tmp/welcome.png", :message=>"Welcome to Guard", :noquiet=>false, :nosound=>false, :time=>3, :title=>"Hello", :type=>:info, :xp=>false})
      # ./lib/notiffany/notifier/rb_notifu.rb:68:in `_perform_notify'
      # ./lib/notiffany/notifier/base.rb:72:in `notify'
      # ./spec/lib/notiffany/notifier/rb_notifu_spec.rb:54:in `block (4 levels) in <class:Notifier>'

  12) Notiffany has a version number
      Failure/Error: expect(Notiffany::VERSION).not_to be nil

      NameError:
        uninitialized constant Notiffany::VERSION
      # ./spec/notiffany_spec.rb:3:in `block (2 levels) in <top (required)>'

Finished in 0.12728 seconds (files took 0.09119 seconds to load)
183 examples, 12 failures, 2 pending

Failed examples:

rspec ./spec/lib/notiffany/notifier/terminal_notifier_spec.rb:67 # Notiffany::Notifier::TerminalNotifier#notify should allow the title to be customized
rspec ./spec/lib/notiffany/notifier/terminal_notifier_spec.rb:57 # Notiffany::Notifier::TerminalNotifier#notify should call the notifier.
rspec ./spec/lib/notiffany/notifier/terminal_notifier_spec.rb:78 # Notiffany::Notifier::TerminalNotifier#notify without a title set should show the app name in the title
rspec ./spec/lib/notiffany/notifier/terminal_notifier_spec.rb:38 # Notiffany::Notifier::TerminalNotifier#notify with options passed at initialization uses these options by default
rspec ./spec/lib/notiffany/notifier/terminal_notifier_spec.rb:45 # Notiffany::Notifier::TerminalNotifier#notify with options passed at initialization overwrites object options with passed options
rspec ./spec/lib/notiffany/notifier/detected_spec.rb:103 # Notiffany::Notifier::Detected#add with manually configured notifiers when not available does not add the library
rspec ./spec/lib/notiffany/notifier/detected_spec.rb:108 # Notiffany::Notifier::Detected#add with manually configured notifiers when not available does not raise an error
rspec ./spec/lib/notiffany/notifier/detected_spec.rb:112 # Notiffany::Notifier::Detected#add with manually configured notifiers when not available shows a warning
rspec ./spec/lib/notiffany/notifier/rb_notifu_spec.rb:101 # Notiffany::Notifier::Notifu#notify with additional options can override the default options
rspec ./spec/lib/notiffany/notifier/rb_notifu_spec.rb:80 # Notiffany::Notifier::Notifu#notify without additional options shows the notification with the default options
rspec ./spec/lib/notiffany/notifier/rb_notifu_spec.rb:40 # Notiffany::Notifier::Notifu#notify with options passed at initialization uses these options by default
rspec ./spec/notiffany_spec.rb:2 # Notiffany has a version number

Randomized with seed 36787