Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow roles to be more easily added #86

Open
kenoir opened this issue Nov 15, 2016 · 4 comments
Open

Allow roles to be more easily added #86

kenoir opened this issue Nov 15, 2016 · 4 comments

Comments

@kenoir
Copy link
Contributor

kenoir commented Nov 15, 2016

I.e. extract them from the Amigo code so a deploy is not required to update the availble roles.

Some suggestions:

  • Move ansible tasks into dynamo and editable in UI.
  • Move ansible tasks per role into S3 and allow updating by pushing to S3 and an agent running within Amigo to update roles.
  • Keep roles in a Github repo, but hook merges to master to some mechanism that updates Amigo with the new set of ansible tasks (possibly by pushing them into S3)
@philwills
Copy link
Contributor

Ansible tasks are code. I'd rather that they were in a VCS than a datastore.

I'm not convinced this would make things easier enough to warrant the added complexity and deviation from normal deployment mechanisms.

@kenoir
Copy link
Contributor Author

kenoir commented Nov 15, 2016

Nah, they're YAML files 😛

In my opinion this is putting config in code - which is fine for things that don't change often, which is not true in this case.

@kenoir
Copy link
Contributor Author

kenoir commented Nov 15, 2016

^ but I would also advocate for keeping changes in version control.

@sihil
Copy link
Contributor

sihil commented Nov 15, 2016

Originally we said that roles etc should be in a different (possibly multiple) git repos. I agree with @philwills that it's still code, but it seems to make sense to me to decouple the amigo app from the roles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants