From f0d08b56fae79731b6c07e043b7935ab2a9fc57b Mon Sep 17 00:00:00 2001 From: Dominik Lander Date: Mon, 21 Oct 2024 15:05:05 +0100 Subject: [PATCH 1/2] Set US Banner test audience to 15% --- .../src/experiments/tests/usa-expandable-marketing-card.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dotcom-rendering/src/experiments/tests/usa-expandable-marketing-card.ts b/dotcom-rendering/src/experiments/tests/usa-expandable-marketing-card.ts index b6194b3a99a..1f9cc1611b9 100644 --- a/dotcom-rendering/src/experiments/tests/usa-expandable-marketing-card.ts +++ b/dotcom-rendering/src/experiments/tests/usa-expandable-marketing-card.ts @@ -7,7 +7,7 @@ export const UsaExpandableMarketingCard: ABTest = { author: 'dotcom.platform@guardian.co.uk', description: 'Test the impact of showing the user a component that highlights the Guardians journalism.', - audience: 0 / 100, + audience: 15 / 100, audienceOffset: 0 / 100, audienceCriteria: 'US-based users that see the US edition.', successMeasure: 'Users are more likely to engage with the site.', From a86151107db6cca1715b22b3529bbc00228c4600 Mon Sep 17 00:00:00 2001 From: Dominik Lander Date: Mon, 21 Oct 2024 16:07:02 +0100 Subject: [PATCH 2/2] improve accuracy of function name --- .../components/ExpandableMarketingCardWrapper.importable.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dotcom-rendering/src/components/ExpandableMarketingCardWrapper.importable.tsx b/dotcom-rendering/src/components/ExpandableMarketingCardWrapper.importable.tsx index 2b558a8a54f..8542f6a22df 100644 --- a/dotcom-rendering/src/components/ExpandableMarketingCardWrapper.importable.tsx +++ b/dotcom-rendering/src/components/ExpandableMarketingCardWrapper.importable.tsx @@ -8,7 +8,7 @@ import { ExpandableMarketingCard } from './ExpandableMarketingCard'; import { ExpandableMarketingCardSwipeable } from './ExpandableMarketingCardSwipeable'; import { Hide } from './Hide'; -const isFirstArticle = () => { +const isFirstOrSecondArticle = () => { const [dailyCount = {} as DailyArticle] = getDailyArticleCount() ?? []; return Object.keys(dailyCount).length === 0 || dailyCount.count <= 1; }; @@ -25,7 +25,7 @@ const isNewUSUser = async () => { !!editionCookie && editionCookie !== 'US'; // This check must happen AFTER we've ensured that the user is in the US. - const isNewUser = isFirstArticle(); + const isNewUser = isFirstOrSecondArticle(); return !hasUserSelectedNonUSEdition && isNewUser; };