Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.0+ Support #252

Closed
aquaflamingo opened this issue May 21, 2022 · 2 comments
Closed

Ruby 3.0+ Support #252

aquaflamingo opened this issue May 21, 2022 · 2 comments

Comments

@aquaflamingo
Copy link

Howdy!

First off, awesome library! Been building a few projects with it, thanks for building this :)

It seems that RSpotify breaks with the move to Ruby 3, specifically it seems centered around the URI.encode method from the looks of this issue:
#236

Seems that the method has now been removed in higher version of Ruby, namely 3.0.

I see a few pull requests open that could help out
#228
#233

Wondering if it would be possible to get them merged. Happy to help out where possible to get these over the line if interested. Let me know, thanks again for the lib! :)

@aquaflamingo
Copy link
Author

Whoops, disregard. Seems that the addressable gem has already been bumped to 2.8.0 in 94d0cc3.

So perhaps those PRs will not help.

@aquaflamingo
Copy link
Author

Ah sincere apologies - this was total user error on my part. Closing !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant