-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SAFT gamma mie : How to add second order parameters #14
Comments
First, I added a parameter like this and ran the following code as you gave me like this.
but I get this error. How can I fix it? Thanks as always for your help! |
Hi YouHyin, This is something I didn't consider before. when I implemented this SAFT I only included the second-order parameters of the following paper: Haslam, A. J., González-Pérez, A., Di Lecce, S., Khalit, S. H., Perdomo, F. A., Kournopoulos, S., Kohns, M., Lindeboom, T., Wehbe, M., Febra, S., Jackson, G., Adjiman, C. S., & Galindo, A. (2020). Expanding the Applications of the SAFT-γMie Group-Contribution Equation of State: Prediction of Thermodynamic Properties and Phase Behavior of Mixtures. Journal of Chemical and Engineering Data, 65(12), 5862–5890. https://doi.org/10.1021/acs.jced.0c00746 As you mentioned, the parameters are stored in the "secondmie" and "secondasso" of the saftgamma_database.xslx file. However, these parameters are only used in very specific molecular environments. In the end, I made custom functions to identify the molecular environment, but this is very manually done, see this file, for example. The other option that you show of replacing the "normal" parameters with the second-order parameters of the entire database should work only if the "normal" parameters were not used elsewhere in your mixture. I think this is the case with the mixture of I hope that helps! |
Hello Gustavo,
And I solved the error (mixture of diethanolamine + co2 + water) as you advised. |
Hi YouHyin, Thank you for coding this. I'm afraid I haven't had the time to go through it yet. Potentially I will include all of these improvements in the next update. Edit: I have already uploaded a new version of the database and updated the function for the second-order interactions. I still need to work on some other improvements before publishing the final update. Thanks! |
Hi YouHyin, Just an update here. I hope that helps in your research! Regards, |
Have you updated to the most recent version? When updating the code, I realized there was a bug when adding new association interactions to the new database. Basically, there were some cases in which the reference name of the site ('e1', 'e2', or 'H') was incorrectly set. I corrected that bug in the updated version. |
Hi YouHyin, I'm glad to see that for DEA, it is working as expected now. I understand your point about MAPA; the thing is that I coded the second-order interactions to be applied only in the described molecular environment, which MAPA doesn't meet for the NH/NH2 groups. You could, in principle, modify those interactions by manually changing the database (as you have done above). As I mentioned, there was a bug when introducing the new association interactions, but now it should be fixed in the recent update. Gustavo |
Thank you so much for the update. |
Hello Gustavo.
I'm trying to put second order parameters (2nd order NH – H2O) in the database in the following paper, do I just add values to the secondmie and secondasso tabs in saftgamma_database.xlsx?
Paper : Perdomo, F.A., et al., A predictive group-contribution framework for the thermodynamic modelling of CO2 absorption in cyclic amines, alkyl polyamines, alkanolamines and phase-change amines: New data and SAFT-γ Mie parameters. Fluid Phase Equilibria, 2023. 566: p. 113635.
Or I wrote this code based on this example(https://github.com/gustavochm/sgtpy/blob/master/examples/GC%20SAFT-Gamma-Mie%20Examples/1.%20Database.ipynb), but I'm not sure how to add the second order parameter because it only shows how to add the unlike Mie potential interaction, association parameters, not the second order parameter.
The text was updated successfully, but these errors were encountered: