Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider to upgrade to the toms748 algorithm #20

Open
ibell opened this issue Sep 24, 2024 · 1 comment
Open

Consider to upgrade to the toms748 algorithm #20

ibell opened this issue Sep 24, 2024 · 1 comment

Comments

@ibell
Copy link

ibell commented Sep 24, 2024

One example here:

rho_ext = brentq(dPsaft_fun, bracket[0], bracket[1],
.

The toms748 algorithm has all the guarantees of brentq but is always faster according to their derivations in the paper references in the scipy docs, hence no reason to not use it I think.

@gustavochm
Copy link
Owner

Hey Ian,

Thank you for raising this issue. You are right. I'll update the density solvers in the next version.

Gustavo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants