Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Master "save" switch #36

Open
guynir42 opened this issue Oct 5, 2022 · 2 comments
Open

Master "save" switch #36

guynir42 opened this issue Oct 5, 2022 · 2 comments
Assignees
@guynir42
Labels
needs decision

Comments

@guynir42
Copy link
Owner

guynir42 commented Oct 5, 2022

Should we pass a "save" switch to the parameters, or directly to functions like download_sources and analyze_sources?
Should there be a separate switch for saving vs. using the DB in general?
@guynir42 guynir42 self-assigned this Oct 5, 2022
@guynir42
Copy link
Owner Author

Need to add checks everywhere that we try to save objects to disk, to only save them if the DB connection is active

@guynir42
Copy link
Owner Author

Write the test for end-to-end without saving

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guynir42 guynir42

Labels
needs decision
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@guynir42