From faaf91f0e19c05223f38647ead25c33a8efa34bb Mon Sep 17 00:00:00 2001 From: Dmitrii Tikhomirov Date: Mon, 26 Feb 2024 22:18:21 -0800 Subject: [PATCH 1/2] Added missed IOException to Reader.read(char[] buf) and Reader.read(char[] buf, int off, int len) methods --- user/super/com/google/gwt/emul/java/io/Reader.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/user/super/com/google/gwt/emul/java/io/Reader.java b/user/super/com/google/gwt/emul/java/io/Reader.java index 54137991e65..63216ad3a92 100644 --- a/user/super/com/google/gwt/emul/java/io/Reader.java +++ b/user/super/com/google/gwt/emul/java/io/Reader.java @@ -59,7 +59,7 @@ public int read() throws IOException { /** * Attempts to fill {@code buf} with characters up to the size of the array. */ - public int read(char[] buf) { + public int read(char[] buf) throws IOException { return read(buf, 0, buf.length); } @@ -67,7 +67,7 @@ public int read(char[] buf) { * Attempts to fill {@code buf} with up to {@code len} characters. Characters * will be stored in {@code buf} starting at index {@code off}. */ - public abstract int read(char[] buf, int off, int len); + public abstract int read(char[] buf, int off, int len) throws IOException; /** * Returns whether the stream is ready for reading characters. From 59e9de9a3ee6617ecd06579cb2810322aa34f068 Mon Sep 17 00:00:00 2001 From: Colin Alworth Date: Mon, 29 Jul 2024 20:21:23 -0500 Subject: [PATCH 2/2] Add api-breakage notes --- tools/api-checker/config/gwt211_212userapi.conf | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tools/api-checker/config/gwt211_212userapi.conf b/tools/api-checker/config/gwt211_212userapi.conf index 1279e029d85..ecd503d03df 100644 --- a/tools/api-checker/config/gwt211_212userapi.conf +++ b/tools/api-checker/config/gwt211_212userapi.conf @@ -149,4 +149,8 @@ excludedPackages com.google.gwt.core.client.impl\ ############################################## #Api whitelist # when adding to the white-list, include comments as to why the addition is -# being made. \ No newline at end of file +# being made. + +# java.io.Reader missing IOException throws for read methods +java.io.Reader::read([C) OVERRIDABLE_METHOD_EXCEPTION_TYPE_CHANGE new method has more exceptions: [Ljava/io/IOException;] +java.io.Reader::read([CII) OVERRIDABLE_METHOD_EXCEPTION_TYPE_CHANGE new method has more exceptions: [Ljava/io/IOException;]