Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two critical errors and jsdoc typo #9

Open
Alex777UAE opened this issue Oct 20, 2016 · 1 comment
Open

Two critical errors and jsdoc typo #9

Alex777UAE opened this issue Oct 20, 2016 · 1 comment

Comments

@Alex777UAE
Copy link
Contributor

Please check my PR.

May be you have some idea I do not get.
As for cut() method, I believe there is no questions.

But statement made in article:

Note that the child node whose parent links to it is always the node with the smallest value among its siblings.

Is not coincide with what I know about fibonacci heap structure from wiki and other

And makes me think you were thinking about something, but I do not see any "profit" of going this way in terms of algorithm complexity.

You can't imply some strict order in double linked list (say .next is always smaller/bigger than .prev).

@Tyriar
Copy link
Member

Tyriar commented Oct 31, 2016

Pushed the PR #8, I'll close this off when I verify and fix the article.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants