-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lambda parameter in SIDARTHE causing problems again #182
Comments
Hi @djinnome, the issue is that this isn't the right function to call when deserializing a MIRA TemplateModel from JSON. The function |
* Error: gyorilab/mira#182 * Multiple controllers are added together * still getting pydantic error * Error: gyorilab/mira#183 * added more .gitignore because of silly things like .idea * added sidarthe amr * Still can't parse SIDARTHE model using mira yet * removed offending lambda to XXlambdaXX in AMR * SIDARTHE MIRA model and SIDARTHE AMR model produce same outputs * cleaned up test_askenet to have more understandable variable names * Confirmed that all of Sabina's models can be converted to ASKEM and loaded into a ScaledBetaNoisePetriNetODESystem without errors. Next up: try to interpret the sympy rate law * AMR can have lambda and it will still pass all tests. (Mira template still needs XXlambdaXX)
* Started notebook for examples regarding TA2 issues for model validation (#178) * Started notebook for examples regarding TA2 issues for model validation * Started notebook to produce AskeNet Model Representation examples in JSON format. Note: created JSON dictionary successfully; Error creating JSON fileg * Success for SIAERDH model conversion to AMR * created AMR for Model2 from custom models (SEIARHD), see JSON file * added total_population as a parameter * Deaceased -> Deceased * Fixed a few more minor errors * added SIRHD and SEIARHDS models * added SIRHD and SEIARHDS models --------- Co-authored-by: Jeremy Zucker <[email protected]> Co-authored-by: sabinala <[email protected]> Co-authored-by: Jeremy Zucker <[email protected]> * remove .idea * gitignore * Update SEIARHD_AMR.json removed git conflicts in favor of local * Fixing issue in deriv method (#187) * Error: gyorilab/mira#182 * Multiple controllers are added together * still getting pydantic error * Error: gyorilab/mira#183 * added more .gitignore because of silly things like .idea * added sidarthe amr * Still can't parse SIDARTHE model using mira yet * removed offending lambda to XXlambdaXX in AMR * SIDARTHE MIRA model and SIDARTHE AMR model produce same outputs * cleaned up test_askenet to have more understandable variable names * Confirmed that all of Sabina's models can be converted to ASKEM and loaded into a ScaledBetaNoisePetriNetODESystem without errors. Next up: try to interpret the sympy rate law * AMR can have lambda and it will still pass all tests. (Mira template still needs XXlambdaXX) * Changes to interfaces to support data IO for TA4 (#190) * added data * added interface_utils * Added updated demo with data processing * revised interfaces with AMR * removed old file * added test for interfaces demo * added results * Add detailed docstrings for TA4 interfaces (#191) * added detailed docstrings for askem interfaces * added return description * indent error * Removed untested `add_uncertainty` from TA4 interfaces (#192) * removed add_uncertainty from TA4 interfaces, as they are not thoroughly tested * fixed test * Add parameter interventions to TA4 interfaces (#193) * first pass at adding interventions to interfaces. Incomplete formatting. * lingering notebook * adding interventions to outputs * messy but it works. * Removed test_samples_intervened_values because it compares timepoint with timepoint_id, which will not work. Added test_load_and_sample_petri_net to confirm it outputs the correct dataframe under intervention * adde expected intervened samples * added load_and_calibrate_and_sample_petri * Cleaned up demo.ipynb * Cleaned up demo.ipynb * cleaned up documentation of assign_interventions_to_timepoints --------- Co-authored-by: Jeremy Zucker <[email protected]> * End-to-end integration of ensemble modeling w/ TA4 (#194) * first pass at ensemble interface for TA4 * processed output of ensemble modeling * added ensemble calibration interface * added tests and docstrings * added timepoints to ensemble output processing * removed lingering files (#199) --------- Co-authored-by: ShantMahserejian <[email protected]> Co-authored-by: Jeremy Zucker <[email protected]> Co-authored-by: sabinala <[email protected]> Co-authored-by: Jeremy Zucker <[email protected]> Co-authored-by: Sam Witty <[email protected]>
* Error: gyorilab/mira#182 * Multiple controllers are added together * still getting pydantic error * Error: gyorilab/mira#183 * added more .gitignore because of silly things like .idea * added sidarthe amr * Still can't parse SIDARTHE model using mira yet * removed offending lambda to XXlambdaXX in AMR * SIDARTHE MIRA model and SIDARTHE AMR model produce same outputs * cleaned up test_askenet to have more understandable variable names * Confirmed that all of Sabina's models can be converted to ASKEM and loaded into a ScaledBetaNoisePetriNetODESystem without errors. Next up: try to interpret the sympy rate law * AMR can have lambda and it will still pass all tests. (Mira template still needs XXlambdaXX)
Hi folks,
When I tried to create an ASKEM Model Representation from the SIDARTHE_mira template model, I ran into the following issue:
The text was updated successfully, but these errors were encountered: