Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackathon Scenario 1 mira model has wrong petri net struture #192

Closed
djinnome opened this issue Jul 6, 2023 · 0 comments
Closed

Hackathon Scenario 1 mira model has wrong petri net struture #192

djinnome opened this issue Jul 6, 2023 · 0 comments

Comments

@djinnome
Copy link

djinnome commented Jul 6, 2023

Hi @bgyori

Hopefully fixing the controller shouldn't be too heavy a lift:

In https://github.com/indralab/mira/blob/hackathon/notebooks/hackathon_2023.07/scenario1.ipynb

cell[4]:

t1 = ControlledConversion(subject=c['S'],
                          outcome=c['E'],
                          controller=c['E'],
                          rate_law=S*I*beta / N)

should be:

t1 = ControlledConversion(subject=c['S'],
                          outcome=c['E'],
                          controller=c['I'],
                          rate_law=S*I*beta / N)

This results in an incorrect AMR:

https://github.com/indralab/mira/blob/36994e15bb0ed935f475bff78e1204445522cfb5/notebooks/hackathon_2023.07/scenario1_a.json#L71-L81

Which should be:

  "transitions": [
   {
    "id": "t1",
    "input": [
     "I",
     "S"
    ],
    "output": [
     "E",
     "I"
    ],
@bgyori bgyori closed this as completed in d084a9a Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant