Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenario 2a (beat_var and beta_scale) are missing initial conditions array #204

Closed
VigneshSella opened this issue Jul 12, 2023 · 2 comments

Comments

@VigneshSella
Copy link

VigneshSella commented Jul 12, 2023

For scenario2a, at this line there should be initial conditions for S,V,A,I,R. I believe the parameter values are:
S = 1
V = [V1, V2] = [0,0]
A = 0
I = 1e-6
R = 0.

This is from the MATLAB data provided by the paper author at their GitHub.

@VigneshSella
Copy link
Author

Looks like the following are undefined initial conditions that should be included in the AMR:
{'S': 1, 'V1': 0.0, 'V2': 0.0, 'A': 0.0, 'I': 1e-6, 'R': 0.0, 'AR': 0.0, 'IR': 0.0, 'IV': 0.0, 'R2': 0.0, 'SVR': 0.0}

Note: Values are not necessarily correct, but I set them to the best of my understanding of the paper and ASKEM scenario handout.

@bgyori
Copy link
Member

bgyori commented Jul 12, 2023

This is fixed on the hackathon branch. The initials were implemented in my notebook, they just weren't correctly included in the output.

@bgyori bgyori closed this as completed Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants