Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenario 2a Incorrect values for parameters #205

Closed
VigneshSella opened this issue Jul 12, 2023 · 3 comments
Closed

Scenario 2a Incorrect values for parameters #205

VigneshSella opened this issue Jul 12, 2023 · 3 comments

Comments

@VigneshSella
Copy link

VigneshSella commented Jul 12, 2023

Beta, beta_v1, beta_v2, beta_R are on the order of 1e-10. Whereas, in the MATLAB data provided by the paper author they are on the order of 1e-3. These values lead into a simulation which drops the # of infected to 0 after starting at 1e-6 (presumably because transmission rates are so low).

This applies to the following .json AMRs:

  1. https://github.com/indralab/mira/blob/hackathon/notebooks/hackathon_2023.07/scenario2_a_beta_scale_static.json
  2. https://github.com/indralab/mira/blob/hackathon/notebooks/hackathon_2023.07/scenario2_a_beta_scale_var.json
@bgyori
Copy link
Member

bgyori commented Jul 12, 2023

Interesting - according to the paper's supplementary materials, my numbers look correct, e.g.

image

Not sure where the difference comes from.

@VigneshSella
Copy link
Author

Not sure either. But to my un-trained eyes these variables names seem slightly different than the ones in the AMR and MATLAB output.mat file. The MATLAB output.mat file has the variables titled as they are in the model, and with the difference in order of magnitude, transmission should be possible as opposed to when the beta variables are as defined (on the order of 1e-9/-10) then the simulation makes # of infected 0 after a few days.

@bgyori
Copy link
Member

bgyori commented Jul 12, 2023

This is resolved on the latest hackathon branch. The issue was that the original model didn't directly use these parameters, they were multiplied by the absolute population first:

https://github.com/MehrshadSD/SARS-CoV-2-variants-of-concern-in-Ontario/blob/main/voc2_driver.m#L7-L12

@bgyori bgyori closed this as completed Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants