Inconsistency in the structure of param_dict

[liunelson]

The param_dict argument of TemplateModel.set_parameters(...) has type dict[str, float] while params_dict of mira.modeling.amr.ops.add_transition(...) has type dict[str, dict[str, Any]].

It's just a minor mismatch in interface that tripped me up.

[bgyori]

I see, those are different by design but I suppose it could be changed. The thinking is as follows:

• for set_parameters, you just provide the value for each input parameter
• for add_transition you have the option to provide an entirely new parameter definition if it appears in the new transition

Do you think set_parameters should allow creating new parameters rather than just allow updating parameter values?

[liunelson]

In this case, I needed to add 6 new parameters and assign values to them. If set_parameters allows creating new parameters, then I could avoid making 6 add_parameter and 1 set_parameters calls. So yes please!