feat(#158): kill detached process on win #159
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #159 +/- ##
=======================================
Coverage 83.15% 83.15%
=======================================
Files 16 16
Lines 285 285
=======================================
Hits 237 237
Misses 48 48 ☔ View full report in Codecov by Sentry. |
|
@l3r8yJ something gets wrong with exiting of the test: Maybe you do know how to fix that? |
|
@h1alexbel I think that use |
|
@l3r8yJ I will try to check problematic test on real windows then |
|
@l3r8yJ I checked out this branch on windows. It looks like server starts in blocking mode, but it should be detached. Probably some flags are misused |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull I've implemented
kill(port)for killing detached process on windows platform, and enabledaccepts_request_in_detached_modeintegration test on windows platform.closes #158
PR-Codex overview
The focus of this PR is to add support for killing ports on Windows platform in the CLI integration tests.
Detailed summary
npm install kill-portinjustfilemain.rs