Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple code tabs (Work in progress) #166

Closed
wants to merge 16 commits into from

Conversation

eddie0329
Copy link
Contributor

@eddie0329 eddie0329 commented Jan 28, 2022

What this PR does / why we need it?

Support mutiple code tabs (Issue: #102)

Any background context you want to provide?

  • Custom scrollbar is implemented due to following reasons:
    • Too large in basic scroll bar
    • Want to deliver same user experience between different OS.

📌 dark mode

Original Scroll bar Customize Scroll Bar
스크린샷 2022-01-28 오전 11 42 04 스크린샷 2022-01-28 오전 11 32 54

📌 light mode

Original Scroll bar Customize Scroll Bar
스크린샷 2022-01-28 오후 12 36 12 스크린샷 2022-01-28 오후 12 34 48

Todo

  • Design each tabs
  • Light mode implementation
  • Handle doc datas when change tab

Block Issue & Question

Q1> Where should i save each tab setting? currently it is Saved in Browser Store.
Q2> What should new tab name should be?
Q3> Which Size of Tab should be better?
same size as side bar smaller size than side bar
스크린샷 2022-01-28 오후 12 15 16 스크린샷 2022-01-28 오후 12 15 38

What are the relevant tickets?

Fixes #102

Checklist

  • Added relevant tests or not required
  • Didn't break anything

@hackerwins hackerwins requested a review from a team January 28, 2022 11:07
@hackerwins
Copy link
Owner

The overall work looks good. There is a lot of work, so please take care of the remaining work.

@eddie0329
Copy link
Contributor Author

The overall work looks good. There is a lot of work, so please take care of the remaining work.

Thanks for reveiw ! I will make sure care of remaining work 😊

@hackerwins
Copy link
Owner

@eddie0329 Thanks for your contribution.

This feature looks useful but has not been updated on for a long time. I'll close this for now. Please let me know if you have any plans to work on this.

@hackerwins hackerwins closed this Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support multiple code tabs
2 participants