Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to load latest available NC boundary json data #1814

Open
5 tasks
ryanfchase opened this issue Sep 7, 2024 · 4 comments
Open
5 tasks

Need to load latest available NC boundary json data #1814

ryanfchase opened this issue Sep 7, 2024 · 4 comments
Assignees
Labels
Complexity: Medium Dependency An issue that includes dependencies p-feature: data ready for dev lead ready for developer lead to review the issue Role: Data Science Data management, loading, or analysis Size: 2pt Can be done in 7-12 hours

Comments

@ryanfchase
Copy link
Member

ryanfchase commented Sep 7, 2024

Dependency

  • Create an Emergent Request detailing why we should consider doing this

Overview

We need to identify and upload the most recent available version of NC boundaries as a json file since the 2019 json data is outdated.

Blocks

Action Items

  • Obtain a more recent json file with NC boundary data
    • comment where you have obtained this data, ideally from a trusted city source
  • test the data by substituting the 2019 json with this new json file
  • upload an image of the new boundary data being rendered on the map

Resources/Instructions

Useful Files and Components

  • districts.js: components/Map/districts.js
    • note: this may not be heavily used
    • L4: importing the data from nc-boundary-2019-modified.json
    • L19: the function `ncInfoFromLngLat
Screenshot before proposed changes

image

Screenshot after proposed changes

[TODO: insert screenshot here]

@ryanfchase ryanfchase added Role: Frontend React front end work Size: 1pt Can be done in 6 hours p-feature: data Complexity: Small labels Sep 7, 2024
@ryanfchase ryanfchase added this to the X - Technical Debt milestone Sep 7, 2024
@ryanfchase ryanfchase added the ready for dev lead ready for developer lead to review the issue label Sep 7, 2024
@ryanfchase
Copy link
Member Author

This ticket is ready for dev lead review -- if this should be a Good First Issue, I can add more instruction to support the new dev in completing the ticket.

@traycn
Copy link
Member

traycn commented Sep 7, 2024

Reviewing as dev lead:
ETA - 9/8
Time - 12pm PT

@ryanfchase ryanfchase self-assigned this Sep 9, 2024
@ryanfchase
Copy link
Member Author

moving this back to draft and assigning myself. As I started to point to areas of the code that would need to change, I realized there's a fair amount of similarly named variables... I need to differentiate between use of ncGeoJson js file, and the nc-boundary-2019-modified.json file.

@ryanfchase ryanfchase removed the ready for dev lead ready for developer lead to review the issue label Sep 9, 2024
@ryanfchase ryanfchase added Role: Data Science Data management, loading, or analysis Size: 2pt Can be done in 7-12 hours Complexity: Medium ready for dev lead ready for developer lead to review the issue Dependency An issue that includes dependencies and removed Size: 1pt Can be done in 6 hours draft Role: Frontend React front end work Complexity: Small labels Sep 25, 2024
@ryanfchase
Copy link
Member Author

I'm moving this very temporarily to Icebox, while I create an ER for this so that the task can be broken down into component pieces, making it easier for devs to tackle without a high degree of guidance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Dependency An issue that includes dependencies p-feature: data ready for dev lead ready for developer lead to review the issue Role: Data Science Data management, loading, or analysis Size: 2pt Can be done in 7-12 hours
Projects
Status: Icebox (on hold)
Development

No branches or pull requests

2 participants