Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Permission Type #147

Closed
2 of 4 tasks
fyliu opened this issue Apr 14, 2023 · 3 comments
Closed
2 of 4 tasks

Missing Permission Type #147

fyliu opened this issue Apr 14, 2023 · 3 comments
Labels
complexity: missing discussion p-feature: permissions role: back end s: org stakeholder: the org (includes stats) s: PD team stakeholder: People Depot Team s: VRMS stakeholder: VRMS size: 0.5pt Can be done in 3 hours or less
Milestone

Comments

@fyliu
Copy link
Member

fyliu commented Apr 14, 2023

Overview

PermissionType data in the tables spreadsheet should include a default permission that has almost no permission, like "Unverified user" or "Pre-onboarded user".

Action Items

  • [team discussion?] decide on a name for the new permission type
  • add a row to the spreadsheet for the name
  • indicate that this is the default permission type
  • move Create Table: permission_type #24 out of ice box

Resources/Instructions

tables spreadsheet

Discussion

Remember that anyone is free to sign up for the cognito account before onboarding and have a valid login to the PD backend. Right now, the lowest permission level is memberGeneral, which I assume has more permission than we want to give a pre-member. For example, we don't want to allow people to start joining projects before they accepted the terms and conditions.

@fyliu fyliu added role: back end size: 0.5pt Can be done in 3 hours or less p-feature: permissions s: VRMS stakeholder: VRMS feature: missing s: PD team stakeholder: People Depot Team s: org stakeholder: the org (includes stats) discussion labels Apr 14, 2023
@fyliu fyliu added this to the 2 - Security milestone Apr 14, 2023
@fyliu fyliu mentioned this issue May 17, 2023
21 tasks
@fyliu
Copy link
Member Author

fyliu commented May 17, 2023

Ethan's work needs this level of no permission, where a registered user should have only public-level access until it's moved to memberGeneral.

@ExperimentsInHonesty
Copy link
Member

ExperimentsInHonesty commented May 19, 2023

We think we don't need another permission type because the user status and check type tables will end up being used in combination to restrict access.

We would also require an app token as well as cognito user token.

Discussion participants
Fang
Bonnie
Shifra

@fyliu
Copy link
Member Author

fyliu commented Aug 11, 2023

To clarify some more: The system would check that user status is "active" and that all the required checks are completed before allowing a user "member" level access to the API.

We need to implement checks for the permission to work, so check_type should be v0.1 . I updated its milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: missing discussion p-feature: permissions role: back end s: org stakeholder: the org (includes stats) s: PD team stakeholder: People Depot Team s: VRMS stakeholder: VRMS size: 0.5pt Can be done in 3 hours or less
Projects
Status: ✅Done
Development

No branches or pull requests

2 participants