Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the DRO and Admin Notes columns for Projects #1650

Open
10 tasks done
entrotech opened this issue Apr 2, 2024 · 5 comments · Fixed by #1881 · May be fixed by #1888
Open
10 tasks done

Implement the DRO and Admin Notes columns for Projects #1650

entrotech opened this issue Apr 2, 2024 · 5 comments · Fixed by #1881 · May be fixed by #1888
Assignees
@dipitvasdev
Labels
enhancement Release Note: Shows as visual or user experience Enhancement level: hard p-feature: My Projects Page /projects pbv: dev All engineering issues priority: MUST HAVE role: back-end Node/Express Development Task role: database Database Development Task role: front-end Front End Developer size: 5pt Can be done in 19-30 hours
Milestone
10 - Launch

Comments

@entrotech
Copy link
Member

entrotech commented Apr 2, 2024 •
edited by dipitvasdev
Loading

Overview

  • Implement the DRO and admin notes columns to Projects

Action Items

  • Add a Dro table to the database with columns, id (pk, int), name nvarchar(200) not null, displayOrder int, not null, default 10 to the database.
  • Add columns droId (int, null, fk to Dro table), and adminNotes varchar(max), null , and dateModifiedAdmin datetime2(7), null, to the Project table.
  • Add the new columns to the SELECT web api call for retrieving projects.
  • Create an update web api call that allows an admin to update the droId column value of a project. When this api is called, the droId column will be updated and the dateModifiedAdmin value will be set to the current datetime (UTC), but do not modify the dateModified column.
  • Add a DRO column to the My Projects page grid. It should be read-only text showing the DRO name if the user is not an admin, or a drop-down list box if the user is an admin. When an admin selects a new value, is should call the updateDro web api call.
  • Create an updateAdminNotes web api call that allows and admin to update the adminNotes column value in the Project table. When this is updated, also update the dateModifiedAdmin column to the current datetime (UTC), but do not update the dateModified column.
  • Add a column to the My Projects grid for Admin Notes. It should display an "add note" (see resources Add Circle) icon if the project has no admin notes, or an "edit note" icon (see resources Edit) if the project has some text in the admin note column. Adding or editing the admin notes, should make the corresponding change to the contents of the project's admin notes column by using the above-mentioned updateAdminNotes web api call. This column should only show if the user is an admin.
  • Add the dateModifiedAdmin column to show in the My Project grid if the user is an admin. Format should be the same as the Created, Modified columns.
  • Filtering for these two new columns will be included on another follow-up issue.
  • Release dependency on Implement Filtering and Sorting for Admin Notes and DRO columns on My Projects Page #1651 and move it from the icebox to the new issue approval column.

Resources/Instructions

Dev, my projects page: https://tdm-dev.azurewebsites.net/projects

For the Edit icon: https://mui.com/material-ui/material-icons/?query=edit&selected=Edit
For the Add Circle icon: https://mui.com/material-ui/material-icons/?query=addc&selected=AddCircle
@entrotech entrotech added enhancement Release Note: Shows as visual or user experience Enhancement milestone: missing role: front-end Front End Developer role: back-end Node/Express Development Task role: database Database Development Task level: medium priority: MUST HAVE p-feature: My Projects Page /projects size: 2pt Can be done in 7-12 hours labels Apr 2, 2024
@entrotech entrotech mentioned this issue Apr 3, 2024
Open
2 tasks
@ExperimentsInHonesty ExperimentsInHonesty added the pbv: dev All engineering issues label Jun 11, 2024
@dipitvasdev dipitvasdev self-assigned this Aug 29, 2024
@ExperimentsInHonesty
Copy link
Member

@dipitvasdev i have moved this issue into the in progress column. In the future, please do that when you self assign.

@ExperimentsInHonesty ExperimentsInHonesty added size: 5pt Can be done in 19-30 hours level: hard and removed size: 2pt Can be done in 7-12 hours level: medium labels Sep 4, 2024
@ExperimentsInHonesty
Copy link
Member

@dipitvasdev Please provide update

  1. Progress: "What is the current status of your project? What have you completed and what is left to do?"
  2. Blockers: "Difficulties or errors encountered."
  3. Availability: "How much time will you have this week to work on this issue?"
  4. ETA: "When do you expect this issue to be completed?"
  5. Pictures or links* (if necessary): "Add any pictures or links that will help illustrate what you are working on."
  • remember to add links to the top of the issue if they are going to be needed again.

@dipitvasdev
Copy link
Member

dipitvasdev commented Sep 11, 2024 •
edited
Loading

Hi @ExperimentsInHonesty, I was having some problems setting up the database so I am working on that. I was moving so was not able to devote that much time. Here is the update in the format you requested:

  • Progress: I am setting up the local database, and their was a issue with my M1 mac and the setup.
  • Blockers: I think I know what steps to talk to solve the blockers, I will discuss with John to take help.
  • Availability: Last week I was unavailable because I was moving, but this week I can devote time to this, I can give over 10 hours (most likely, It won't take that much time)
  • ETA: before Oct 1

@dipitvasdev dipitvasdev mentioned this issue Sep 26, 2024
Merged
@ExperimentsInHonesty
Copy link
Member

@dipitvasdev here are some changes for the DRO column

Change the names of the DROs to exclude the words Development Review Office

The names become
Metro
Valley
West LA

Make sure the drop-down is alphabetized

Add a value "Select..." so that when if they choose one but later realize it's the wrong one, they can choose Select...

@dipitvasdev
Copy link
Member

Okay @ExperimentsInHonesty, I'll work on those changes

@dipitvasdev dipitvasdev linked a pull request Oct 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dipitvasdev dipitvasdev

Labels
enhancement Release Note: Shows as visual or user experience Enhancement level: hard p-feature: My Projects Page /projects pbv: dev All engineering issues priority: MUST HAVE role: back-end Node/Express Development Task role: database Database Development Task role: front-end Front End Developer size: 5pt Can be done in 19-30 hours
Projects
P: TDM: project board
Status: In progress (actively working)
Milestone
10 - Launch
4 participants
@entrotech @dipitvasdev @ExperimentsInHonesty @Parisajf