New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove use of inline scripts with google analytics #59

Open

jamemackson opened this issue Jul 21, 2015 · 0 comments

Labels

Milestone

post launch sometime

Member

jamemackson commented Jul 21, 2015

As discussed in #57 here we should update the logic surrounding our use of Google Analytics scripts to eliminate needing to allow inline scripts.

I think to get away from the inline script approach we would have to model our solution in a similar fashion to how their are loading the live reload script with ember-cli ember-cli-inject-live-reload.
I'm thinking we should make create an issue for this and circle back later on this. Maybe give a PR to ember-cli-google-analytics at that time and migrate to using that.

jamemackson added the enhancement label

jamemackson added this to the post launch sometime milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment