Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

期望 TemplateHeadProcessor 代码注入不会影响到错误页面 #6500

Closed
LIlGG opened this issue Aug 23, 2024 · 0 comments · Fixed by #6709
Closed

期望 TemplateHeadProcessor 代码注入不会影响到错误页面 #6500

LIlGG opened this issue Aug 23, 2024 · 0 comments · Fixed by #6709
Assignees
@guqing
Labels
area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement.
Milestone
2.20.0 LTS

Comments

@LIlGG
Copy link
Member

LIlGG commented Aug 23, 2024 •
edited
Loading

你当前使用的版本

2.18.0

描述一下此特性

当前插件使用 TemplateHeadProcessor 扩展点为前端页面注入代码，但如果插件实现的 TemplateHeadProcessor 抛出异常，错误页面（如 404、4xx、500、5xx）也会被影响，导致错误页面出现报错，无法正常发挥作用。

为了避免错误页面被影响，期望 TemplateHeadProcessor 不会在错误页面中注入代码。防止插件抛出的异常干扰错误页面的正常展示。

/kind improvement
/area core

附加信息

No response
@f2c-ci-robot f2c-ci-robot bot added kind/improvement Categorizes issue or PR as related to a improvement. area/core Issues or PRs related to the Halo Core labels Aug 23, 2024
@ruibaby ruibaby added this to the 2.20.x milestone Sep 12, 2024
@guqing guqing mentioned this issue Sep 26, 2024
Merged
@ruibaby ruibaby mentioned this issue Oct 5, 2024
Closed
@f2c-ci-robot f2c-ci-robot bot closed this as completed in 02c5484 Oct 10, 2024
@ruibaby ruibaby modified the milestones: 2.20.x, 2.20.0 LTS Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@guqing guqing

Labels
area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement.
Projects
None yet
Milestone
2.20.0 LTS
Development

Successfully merging a pull request may close this issue.

refactor: head and footer tag injection to skip error pages guqing/halo
3 participants
@ruibaby @LIlGG @guqing