-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --template option to generators producing view templates #230
Comments
Hi @Atelier-Mirai, thanks for your feedback! The good news is that we already have first class support for Slim with the view layer we reintroduced in Hanami 2.1. Any Unfortunately, our generators currently do not produce Slim templates. That If you'd like to open PRs bringing this flag back, I'd be very happy to review and accept them. Please also include Haml support, which is our other officially supported template engine :) |
Thank you for your guidance. I can now use slim templates by writing As a newbie, I do not have the ability to issue a PR and have manually changed from I would like to donate $1 as a thank you, is it possible, I am looking forward to the completion of 2.2.0. |
@timriley I can take it, since there are no takers. Would you want it for 2.2 release1? Also one question for clarification: The original report mentions Footnotes
|
I am very happy to reply from you. It was my understanding that each time I use slim, I need to write the template options. Example 1
Slim is specified as the default format. Therefore, the template option will not be necessary next time. This is very convenient and appreciated. Example 2
Example 2 is more convenient, but if it is difficult to implement, just Example 1 is fine. I really appreciate your willingness to work on the implementation. |
@katafrakt I'd love it if you could pick this up, thank you! This one feels like a bit of a stretch to include in the upcoming 2.2 release. However, I plan for releases to be smaller and more frequent after 2.2, so I wouldn't expect things like this to be stuck inside git repos forever. The reason I say it feels like a stretch relates to your question:
I think the ideal experience would be for a preferred template type to be saved somewhere so that the user doesn't have to specify it on every CLI invocation (which would be pretty annoying, I think). This expands the scope of this PR a little. There are several ways we might implement something like this, so I'd like to make sure we have the breathing room to get it right and do it well. Does that make sense? I certainly don't want this to feel like a downer. I'm very excited to see you're interested in taking this on! |
@timriley sure, that makes sense, of course. If the defaults should be stored that's indeed almost a new feature and probably unwise to introduce between the RC and final. We can get back to discussing the details here after the release. |
I like slim templates and would like to use them in HANAMI.
--template option
The FEATURES.md file contains the following.
I executed the following command.
Is the
--template
option already obsolete?generate slim template
The following command was executed to generate the action.
The
app/templates/home/show.html.erb
is created.How do I configure it to generate a show.html.slim instead of a show.html.erb?
Versions of Hanami are as follows.
Thank you very much for your time, and we appreciate your response.
The text was updated successfully, but these errors were encountered: