Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minecraft's weird window behavior #13

Open
kamild1996 opened this issue Jan 29, 2017 · 6 comments
Open

Minecraft's weird window behavior #13

kamild1996 opened this issue Jan 29, 2017 · 6 comments

Comments

@kamild1996
Copy link

On the 1.4.1 version of mod, I found out that on certain situations, after leaving fullscreen mode, Minecraft window cannot be resized. Also, the window sometimes lacks the border. Generally, some unexpected behavior is happening there :)

First way to reproduce:

  • Start Minecraft with fullscreen on startup enabled - screen is going to blink several times, finally the game will start in what would look like is fullscreen mode, but in fact it's just a maximized window with no borders (screenshot #1)
  • Press F11. The game will get its border back, but you will no longer be able to resize the window (screenshot #2)
  • After going fullscreen again (F11), the game will properly switch modes, and after another F11 press, the game will return to fully functional windowed mode, which can be resized.

Second way to reproduce:

  • Start Minecraft in windowed mode, then go to settings and enable "Fullscreen" - this way, the game will switch to the "maximized window with no borders" mode described above, and a subsequent F11 press will result in a non-resizable Minecraft window.
hancin added a commit that referenced this issue Jan 29, 2017
Allow us to respond to change in the in-game config screen, adressing
issues in #13 and making the mod easier to use.

Synchronize mod state and Minecraft internal state.
@hancin
Copy link
Owner

hancin commented Jan 29, 2017

Hi there,

I've reproduced the issue you've mentioned and fixed it in latest version 1.5.0. The same issue happening in #11 was at play here, and I forgot there was an in-game config option available.

The mod will now update its own internal state when you change the config there, so there is no longer different behavior when you press F11 or use the in-game config (or options.txt directly).

Cheers

@kamild1996
Copy link
Author

Thank you for fixing it up, works great now!

Interestingly enough, before fixing this issue, this OptiFine bug no longer occured to me when I had your mod installed. But now it happens again. Just mentioning though :)

@hancin
Copy link
Owner

hancin commented Jan 30, 2017

In the newer version, my mod updates Minecraft itself with the state of the window (fullscreen / not fullscreen) while it did not do that before.

Also, to fix a different bug #14, I changed how the resizing process happen here. Maybe the fact that I did it wrong, causing multiple display updates, got around that issue you're having.

I cannot guarantee the support of Optifine with my mod, but I do make an effort to test with it installed as I feel borderless fullscreen is a nice addition to the game and so is Optifine.

@hancin hancin closed this as completed Jan 30, 2017
@starg09
Copy link

starg09 commented Mar 12, 2017

Seems like this still happens, even on default configs? Can replicate in Forge 2254 and 2255 (1.10.2 and 1.11.2) 🙁

Quick edit: I mean both this and #11, going fullscreen once (either through config, F11 or video settings) will disable resizing once you turn FS off...

@hancin
Copy link
Owner

hancin commented Apr 4, 2017

Hi there,

I'll investigate this to see what I can do. It seems this is a race condition in LWJGL itself.

Cheers

@hancin hancin reopened this Apr 4, 2017
@IkeKap
Copy link

IkeKap commented Nov 5, 2017

Pressing f11 in the latest version of MC (1.12.2) and recommended version of forge (1.12.2 - 14.23.0.2491) seems to cause a misaligned window. If you need addition details, please mention me.

See attached img
2017-11-04

comp500 added a commit to comp500/Fullscreen-Windowed-Minecraft that referenced this issue Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants