allow dynamic partial blocks with empty close #1422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why I closed this. |
|
Added to backlog. Since it is a language change and we need a spec first. |
|
I think it would be better to close this PR and re-open it in https://github.com/handlebars-lang/handlebars-parser. |
|
@jstewmon sorry for not doing anything on this PR all the time. My question is: Do you still need this PR? @jaylinski is right: This PR should now be done in the https://github.com/handlebars-lang/handlebars-parser. I think in this repo it does not make sense anymore, because we need the change in the parser-repo for 5.0 anyway. |
|
@nknapp no worries - I don't need this anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1371