Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find better way for implicit checks in check404 #84

Open
hannob opened this issue Oct 31, 2024 · 2 comments
Open

Find better way for implicit checks in check404 #84

hannob opened this issue Oct 31, 2024 · 2 comments

Comments

@hannob
Copy link
Owner

hannob commented Oct 31, 2024

The check404 function does some implicit checks (e.g. webpages with django debugging enabled) by parsing the 404 error page.

This design has the downside that it is not possible to explicitly call those checks (e.g., snallygaster -t djangodebug [host]).

One idea would be to change the code like this:

  • There is a function get404page that fetches the 404 page on the first call, and caches it. On subsequent calls it only serves the cached version.
  • django_debug and other checks (errorpage_with_php etc.) all go into their own test/function and call this.

This would both allow calling those tests separately, but would not slow them down with multiple fetches if we do a full host scan.

@hannob
Copy link
Owner Author

hannob commented Oct 31, 2024

cc @hartwork

@hartwork
Copy link
Contributor

Sounds like the right direction for a start 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants