Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix carbon ads and nuxt target 'static' #439

Open
Nargonath opened this issue Nov 20, 2020 · 2 comments
Open

Fix carbon ads and nuxt target 'static' #439

Nargonath opened this issue Nov 20, 2020 · 2 comments
Labels
bug Bug or defect

Comments

@Nargonath
Copy link
Member

Nargonath commented Nov 20, 2020

Support plan

  • is this issue currently blocking your project? (yes/no):
  • is this issue affecting a production system? (yes/no):

Context

  • node version:
  • module version with issue:
  • last module version without issue:
  • environment (e.g. node, browser, native):
  • used with (e.g. hapi application, another framework, standalone, ...):
  • any other relevant information:

What are you trying to achieve or the steps to reproduce?

const some = 'properly formatted code example';

What was the result you got?

When building the website using target: 'static' in nuxt.config.js the carbon ads script tag is not added to the DOM hence ads are not showing up.

What result did you expect?

Ads should be displayed. We've removed the target: 'static' for now (#438)

Perhaps the problem comes from the mounted lifecycle which is not triggered when generating the website statically.

@Nargonath Nargonath added the bug Bug or defect label Nov 20, 2020
@geek
Copy link
Member

geek commented Jul 30, 2023

@Nargonath is this still valid?

@Nargonath
Copy link
Member Author

@geek I haven't retested but unless somebody fixed it I would assumed it's still the same. Perhaps we don't care about the target: 'static' configuration though. I don't remember exactly the difference between the two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug or defect
Projects
None yet
Development

No branches or pull requests

2 participants