Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to add annotations to ServiceAccount #1056

Open
martinporoli opened this issue Dec 13, 2023 · 1 comment · May be fixed by haproxy-ingress/charts#82
Open

Possibility to add annotations to ServiceAccount #1056

martinporoli opened this issue Dec 13, 2023 · 1 comment · May be fixed by haproxy-ingress/charts#82

Comments

@martinporoli
Copy link

What are you trying to do
I'm running EKS on AWS and want to associate the service account created by HAProxy Ingress to a role in AWS, having something like this in my values.yaml:

serviceAccount:
  annotations:
     eks.amazonaws.com/role-arn: "arn:aws:iam::111111111111:role/some-role-name"

What HAProxy Ingress should do or how it should behave differently
HAProxy Ingress does not support adding annotations to the created ServiceAccount in this way. There are probably alternatives to this approach: maybe overwriting template files or predefining a ServiceAccount connect it using its name. Those approaches would require more setup though and are therefore less ideal in my opinion.

Copy link

This issue got stale and will be closed in 7 days.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2024
@jcmoraisjr jcmoraisjr reopened this Jan 22, 2024
fredrik-w pushed a commit to fredrik-w/haproxy-ingress-charts that referenced this issue Jul 4, 2024
Allow specifying annotations that will be added to the ServiceAccount.
This fixes jcmoraisjr/haproxy-ingress/issues/1056.
fredrik-w pushed a commit to fredrik-w/haproxy-ingress-charts that referenced this issue Sep 16, 2024
Allow specifying annotations that will be added to the ServiceAccount.
This fixes jcmoraisjr/haproxy-ingress/issues/1056.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants