Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor :: Remove global functions from src/helper.php #5

Open
harikt opened this issue Sep 28, 2017 · 3 comments
Open

Refactor :: Remove global functions from src/helper.php #5

harikt opened this issue Sep 28, 2017 · 3 comments

Comments

@harikt
Copy link
Owner

harikt commented Sep 28, 2017

These functions are a copy of the laravel functions though its implementation has changed a bit.

We need to remove the usages and finally remove the file.

@Tjoosten
Copy link

I would like to dig into it

@harikt
Copy link
Owner Author

harikt commented Oct 1, 2017

@Tjoosten sure. There are references to many global functions, so make sure there exists none.

Thank you.

@harikt
Copy link
Owner Author

harikt commented Oct 10, 2017

Remove one by one

  1. storage_path
  2. base_path
  3. public_path : used by asset_file_url

Eg : In this LaravelApplicationDirectories pass the values via constructor.

@harikt harikt changed the title Remove src/helper.php Remove functions from src/helper.php ( Need to search / replace accordingly ) Oct 10, 2017
@harikt harikt changed the title Remove functions from src/helper.php ( Need to search / replace accordingly ) Refactor :: Remove global functions from src/helper.php Jun 1, 2018
@harikt harikt added the enhancement label Jun 27, 2019 — with GitSpeak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants