Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript types missing in v10.16.5 #741

Open
theycallmeswift opened this issue Aug 28, 2024 · 2 comments
Open

Typescript types missing in v10.16.5 #741

theycallmeswift opened this issue Aug 28, 2024 · 2 comments
Labels

Comments

@theycallmeswift
Copy link

TS7016: Could not find a declaration file for module 'liquidjs'. '/Users/theycallmeswift/dev/foo/node_modules/liquidjs/dist/liquid.node.mjs' implicitly has an 'any' type.
  Try `npm i --save-dev @types/liquidjs` if it exists or add a new declaration (.d.ts) file containing `declare module 'liquidjs';`

Works in 10.16.4, but breaks when the packages is upgraded. Likely related to the ESM changes.

@harttle harttle added the bug label Aug 28, 2024
@harttle
Copy link
Owner

harttle commented Aug 28, 2024

I cannot reproduce using this project: https://github.com/harttle/liquidjs/tree/master/demo/typescript

Could you provide a runnable case, maybe a temporary repo, or create a PR to add a repo under /demo?

@skorfmann
Copy link

can confirm that the most recent version didn't have types, downgraded to 10.16.1 (the version I was using before) which worked. Don't have a case to reproduce unfortunately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants