Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requires_login shouldn't redirect on XHR #23

Open
jace opened this issue Apr 20, 2017 · 0 comments
Open

requires_login shouldn't redirect on XHR #23

jace opened this issue Apr 20, 2017 · 0 comments
Assignees

Comments

@jace
Copy link
Member

jace commented Apr 20, 2017

An XHR request without credentials will currently attempt to redirect to /login, which breaks UI as JS will attempt to follow the redirect instead of recognising the lack of access. XHR login fails should return with a 401 instead and perhaps a JSON body {"status": "error", "error": "login_required"}.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants