-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppSideNav
- Component branch (HDS-3800)
#2384
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Cristiano Rastelli <[email protected]>
Co-authored-by: Alex <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Individual changes were reviewed in separate PRs. I would suggest rebasing this PR to main to resolve the one conflict highlighted in the website docs around the deprecation badge.
website/docs/components/app-side-nav/partials/version-history/4.10.0.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really clean code and good tests. I know this has been a journey, but I think this is very good work.
STATUS: PR has been approved.
📌 Summary
If merged, this PR will add the
AppSideNav
component to HDS & deprecate theSideNav
.Previews:
🛠️ Detailed description
The majority of code was duplicated from the
SideNav
and then modified to implement the newAppSideNav
component.Major differences of note:
AppSideNav
has an updated visual design using lighter colors than theSideNav
:header
,:footer
,:body
,:root
:logo
&:actions
child named blocks were removed (used in old :header)Header
andHeader::HomeLink
child components were removed.AppHeader
which already includes this(Spike of restructured List and ListTitle which may be explored in later iterations)
(Internal references: RFC, Meta CRD)
🔗 External links
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.