diff --git a/.changeset/dull-lamps-retire.md b/.changeset/dull-lamps-retire.md new file mode 100644 index 0000000000..8aee717dae --- /dev/null +++ b/.changeset/dull-lamps-retire.md @@ -0,0 +1,11 @@ +--- +"@hashicorp/design-system-components": minor +--- + +`Hds::DialogPrimitive` +- Fixed error in `Description` and `Body` subcomponents, by not passing the `args` argument from the constructor to `super` +- Added missing arguments in `Arg` TypeScript signature object + +`Hds::Modal` +- Fixed error in `Body` subcomponent, caused by not passing the `args` argument from the constructor to `super` +- Added missing arguments in `Arg` TypeScript signature object diff --git a/packages/components/src/components/hds/flyout/body.ts b/packages/components/src/components/hds/flyout/body.ts index ab6cca0fec..7d6c88fe5b 100644 --- a/packages/components/src/components/hds/flyout/body.ts +++ b/packages/components/src/components/hds/flyout/body.ts @@ -7,6 +7,7 @@ import Component from '@glimmer/component'; import { deprecate } from '@ember/debug'; export interface HdsFlyoutBodySignature { + Args: never; Blocks: { default: []; }; @@ -14,8 +15,8 @@ export interface HdsFlyoutBodySignature { } export default class HdsFlyoutBody extends Component { - constructor(owner: unknown) { - super(owner, {}); + constructor(owner: unknown, args: HdsFlyoutBodySignature['Args']) { + super(owner, args); deprecate( 'The `Hds::Flyout::Body` sub-component is now deprecated and will be removed in the next major version of `@hashicorp/design-system-components`. Use `Hds::DialogPrimitive::Body` as one-to-one replacement.', diff --git a/packages/components/src/components/hds/flyout/description.ts b/packages/components/src/components/hds/flyout/description.ts index e72bb69ea6..4f0b30a3f9 100644 --- a/packages/components/src/components/hds/flyout/description.ts +++ b/packages/components/src/components/hds/flyout/description.ts @@ -8,6 +8,7 @@ import { deprecate } from '@ember/debug'; import type { HdsTextBodySignature } from '../text/body'; export interface HdsFlyoutDescriptionSignature { + Args: never; Blocks: { default: []; }; @@ -15,8 +16,8 @@ export interface HdsFlyoutDescriptionSignature { } export default class HdsFlyoutDescription extends Component { - constructor(owner: unknown) { - super(owner, {}); + constructor(owner: unknown, args: HdsFlyoutDescriptionSignature['Args']) { + super(owner, args); deprecate( 'The `Hds::Flyout::Description` sub-component is now deprecated and will be removed in the next major version of `@hashicorp/design-system-components`. Use `Hds::DialogPrimitive::Description` as one-to-one replacement.', diff --git a/packages/components/src/components/hds/modal/body.ts b/packages/components/src/components/hds/modal/body.ts index f2139b4a31..0e0d0ee180 100644 --- a/packages/components/src/components/hds/modal/body.ts +++ b/packages/components/src/components/hds/modal/body.ts @@ -7,6 +7,7 @@ import Component from '@glimmer/component'; import { deprecate } from '@ember/debug'; export interface HdsModalBodySignature { + Args: never; Blocks: { default: []; }; @@ -14,8 +15,8 @@ export interface HdsModalBodySignature { } export default class HdsModalBody extends Component { - constructor(owner: unknown) { - super(owner, {}); + constructor(owner: unknown, args: HdsModalBodySignature['Args']) { + super(owner, args); deprecate( 'The `Hds::Modal::Body` sub-component is now deprecated and will be removed in the next major version of `@hashicorp/design-system-components`. Use `Hds::DialogPrimitive::Body` as one-to-one replacement.',