diff --git a/examples/test/main.tf b/examples/test/main.tf deleted file mode 100644 index dff03f8b3..000000000 --- a/examples/test/main.tf +++ /dev/null @@ -1,24 +0,0 @@ -terraform { - required_providers { - hcp = { - source = "localhost/providers/hcp" - version = "~>0.0.1" - } - } -} - -provider "hcp" { - project_id = "567f02be-08ef-4609-b928-702577572393" -} - - -resource "hcp_service_principal" "example" { - name = "example-sp" -} - -resource "hcp_project_iam_binding" "example" { - principal_id = hcp_service_principal.example.resource_id - role = "roles/admin" -} - - diff --git a/internal/provider/vaultsecrets/resource_vault_secrets_app_test.go b/internal/provider/vaultsecrets/resource_vault_secrets_app_test.go index 7275cc174..3a9536ccf 100644 --- a/internal/provider/vaultsecrets/resource_vault_secrets_app_test.go +++ b/internal/provider/vaultsecrets/resource_vault_secrets_app_test.go @@ -31,6 +31,17 @@ func TestAccVaultSecretsResourceApp(t *testing.T) { resource.TestCheckResourceAttr("hcp_vault_secrets_app.example", "project_id", projectID), ), }, + { + Config: fmt.Sprintf(` + resource "hcp_vault_secrets_app" "example" { + app_name = %q + description = "Acceptance test run" + }`, testAppName), + Check: resource.ComposeTestCheckFunc( + resource.TestCheckResourceAttr("hcp_vault_secrets_app.example", "app_name", testAppName), + resource.TestCheckResourceAttr("hcp_vault_secrets_app.example", "description", "Acceptance test run"), + ), + }, }, }) } diff --git a/internal/provider/vaultsecrets/resource_vault_secrets_secret_test.go b/internal/provider/vaultsecrets/resource_vault_secrets_secret_test.go index 398c5552c..a8d04be20 100644 --- a/internal/provider/vaultsecrets/resource_vault_secrets_secret_test.go +++ b/internal/provider/vaultsecrets/resource_vault_secrets_secret_test.go @@ -13,23 +13,41 @@ import ( ) func TestAccVaultSecretsResourceSecret(t *testing.T) { - testAppName := generateRandomSlug() + testAppName1 := generateRandomSlug() + testAppName2 := generateRandomSlug() projectID := os.Getenv("HCP_PROJECT_ID") resource.Test(t, resource.TestCase{ ProtoV6ProviderFactories: acctest.ProtoV6ProviderFactories, Steps: []resource.TestStep{ + + { + PreConfig: func() { + createTestApp(t, testAppName1) + }, + Config: fmt.Sprintf(` + resource "hcp_vault_secrets_secret" "example" { + app_name = %q + secret_name = "test_secret" + secret_value = "super secret" + }`, testAppName1), + Check: resource.ComposeTestCheckFunc( + resource.TestCheckResourceAttr("hcp_vault_secrets_secret.example", "app_name", testAppName1), + resource.TestCheckResourceAttr("hcp_vault_secrets_secret.example", "secret_name", "test_secret"), + resource.TestCheckResourceAttr("hcp_vault_secrets_secret.example", "secret_value", "super secret"), + ), + }, { PreConfig: func() { - createTestApp(t, testAppName) + createTestApp(t, testAppName2) }, Config: fmt.Sprintf(` resource "hcp_vault_secrets_secret" "example" { app_name = %q secret_name = "test_secret" secret_value = "super secret" - }`, testAppName), + }`, testAppName2), Check: resource.ComposeTestCheckFunc( - resource.TestCheckResourceAttr("hcp_vault_secrets_secret.example", "app_name", testAppName), + resource.TestCheckResourceAttr("hcp_vault_secrets_secret.example", "app_name", testAppName2), resource.TestCheckResourceAttr("hcp_vault_secrets_secret.example", "secret_name", "test_secret"), resource.TestCheckResourceAttr("hcp_vault_secrets_secret.example", "secret_value", "super secret"), resource.TestCheckResourceAttr("hcp_vault_secrets_secret.example", "project_id", projectID),