Group member order is preserved, causing spurious updates

[cliffchapmanrbx]

Terraform Version and Provider Version

Terraform version: v1.6.4
HCP provider version: v0.90.0

Affected Resource(s)

• hcp_group_members

Terraform Configuration Files

locals {
  org_admin_emails = [
    "[email protected]",
    "[email protected]",
    "[email protected]",
    "[email protected]",
  ]
  org_admin_humans = [for u in data.hcp_user_principal.humans : u.user_id]
}

resource "hcp_group" "org-admins" {
  display_name = "Org Admins"
  description  = "Accounts for managing the whole HCP org."
}

resource "hcp_group_members" org-admins {
  group = hcp_group.org-admins.resource_name
    # Note, service principals can't be added to a group.
  members = local.org_admin_humans
}

Debug Output

The order of the list elements changed unexpectedly, causing a spurious change. This is the only relevant output:

Terraform will perform the following actions:

  # hcp_group_members.org-admins will be updated in-place
  ~ resource "hcp_group_members" "org-admins" {
      ~ members = [
          - "38-redacted-5d",
          - "44-redacted-dd",
            "4d-redacted-39",
            "d7-redacted-67",
          + "38-redacted-5d",
          + "44-redacted-dd",
        ]
        # (1 unchanged attribute hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Expected Behavior

The group member list is treated as unordered, and only adding/removing list entries causes a change.

Workaround

Add a sort to the list.

org_admin_humans = sort([for u in data.hcp_user_principal.humans : u.user_id])

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment