Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualbox version detection: handle WARNING lines #13394

Merged

Conversation

paulcacheux
Copy link
Contributor

As reported in https://www.virtualbox.org/ticket/22060, starting with Virtualbox 7.0.16 running:

$ vboxmanage --version
WARNING: Environment variable LOGNAME or USER does not correspond to effective user id.
7.0.18r162988

the warning line is written to stdout which is an issue since the parsing of the version is used in the provider code to use the correct class to handle following communication with Virtualbox.

This PR improves the version detection by parsing the version in the first line that does not start with WARNING:.

@paulcacheux
Copy link
Contributor Author

@chrisroberts would you mind taking a look at this? Thanks a lot 👍

Copy link
Member

@chrisroberts chrisroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chrisroberts chrisroberts merged commit 4b7a465 into hashicorp:main Jul 10, 2024
14 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants