Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass docker exec_options to executor as kwargs #13488

Merged

Conversation

allisonlarson
Copy link
Member

Updates the passing of exec_options as kwargs to the docker local executor, where passing without the ** was deprecated in Ruby 2.7 and broke in 3.0. Without the double splat, the hash was passed as an element in the exec_cmd (splatted) array.

fixes #13388

@allisonlarson allisonlarson added this pull request to the merge queue Aug 15, 2024
@chrisroberts chrisroberts removed this pull request from the merge queue due to the queue being cleared Aug 15, 2024
@allisonlarson allisonlarson merged commit c5da008 into hashicorp:main Aug 15, 2024
12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArgumentError (all arguments must be String) when using docker-exec
2 participants