Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nfsd update command for restart #13490

Merged
merged 3 commits into from
Aug 27, 2024

Conversation

allisonlarson
Copy link
Member

@allisonlarson allisonlarson commented Aug 20, 2024

Updates the nfs_restart_command for darwin hosts to use update instead of restart, after mac Sonoma update. Also adjusts the nfs mount log to run within the block, so it can access the opts hash.

fixes #13364

Copy link
Member

@chrisroberts chrisroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the nfs_restart_command capability is defined, and the export wants to just do an update, it would be better to add a new nfs_update_command capability here and then update the nfs_export to call that.

Copy link
Member

@chrisroberts chrisroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@allisonlarson allisonlarson merged commit a92fbc8 into hashicorp:main Aug 27, 2024
12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

synced_folder fails for NFS on Sonoma 14.4
2 participants