Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass options to initOAuth #109

Open
sir4ur0n opened this issue Jun 29, 2023 · 1 comment
Open

Pass options to initOAuth #109

sir4ur0n opened this issue Jun 29, 2023 · 1 comment

Comments

@sir4ur0n
Copy link

According to https://swagger.io/docs/open-source-tools/swagger-ui/usage/oauth2/ it's possible to pass some default values to initOAuth, e.g. clientId, so that users do not have to type it every time they log in.

Is this possible with any of the Swagger UIs provided by this package?

  • servant-swagger-ui: I don't find any occurrence of clientId, client_id or initOAuth
  • servant-swagger-ui-jensoleg: I do find a call to initOAuth, however the values seem hardcoded? Including the clientId: "ffe7748a-3a3f-4860-a02a-42ab08e4fde2" 🤔
  • ``servant-swagger-ui-redoc: I don't find any occurrence of clientId`, `client_id` or `initOAuth`

If not currently possible: what do you think about adding support for that?

@ysangkok
Copy link
Collaborator

ysangkok commented Jul 4, 2023

The hardcoded client ID does seem to be a bug. I haven't used jensoleg. I wouldn't oppose a clean patch that adds the support, but I would have a hard time reviewing it, as I don't know much about OAuth. So it would have to be properly documented and tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants