Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out hie-bios normalise import-dirs and TargetFile already ? #4257

Closed
soulomoon opened this issue May 27, 2024 · 1 comment · Fixed by #4280
Closed

Figure out hie-bios normalise import-dirs and TargetFile already ? #4257

soulomoon opened this issue May 27, 2024 · 1 comment · Fixed by #4280

Comments

@soulomoon
Copy link
Collaborator

Sidenote: extremely strictly speaking, this should be unnecessary, as hie-bios should normalise import-dirs and TargetFile already. But perhaps we should simply open an issue to investigate later.

Originally posted by @fendor in #4231 (comment)
@soulomoon soulomoon mentioned this issue May 27, 2024
Merged
5 tasks
@soulomoon soulomoon changed the title Figure out hie-bios should normalise import-dirs and TargetFile already Figure out hie-bios normalise import-dirs and TargetFile already ? May 27, 2024
@soulomoon
Copy link
Collaborator Author

soulomoon commented Jun 6, 2024 •
edited
Loading

haskell-language-server/ghcide/session-loader/Development/IDE/Session.hs

Line 1246 in 322ac35

makeDynFlagsAbsolute compRoot -- makeDynFlagsAbsolute already accounts for workingDirectory

It we do make it absolute already

@soulomoon soulomoon mentioned this issue Jun 6, 2024
Merged
@soulomoon soulomoon linked a pull request Jun 6, 2024 that will close this issue
Remove redudant absolutization in session loader #4280
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove redudant absolutization in session loader haskell/haskell-language-server
1 participant
@soulomoon