We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I thing we should remove this: https://github.com/hastic/hastic-server/blob/765cfc7710b2384959bcc11dcac173dd0ab05d68/server/src/services/analytics_service.ts#L207
I found hardcoded port here: https://github.com/hastic/hastic-server/blob/765cfc7710b2384959bcc11dcac173dd0ab05d68/server/src/services/analytics_service.ts#L79
I find it suspicious that we resolve our promise here: https://github.com/hastic/hastic-server/blob/765cfc7710b2384959bcc11dcac173dd0ab05d68/server/src/services/analytics_service.ts#L147
we don't guarantee that task will be sent in the same order (because we just place task to the scheduler, but don't know when scheduler will take it): https://github.com/hastic/hastic-server/blob/765cfc7710b2384959bcc11dcac173dd0ab05d68/server/src/services/analytics_service.ts#L163 .. and we don't await this send function promise
The text was updated successfully, but these errors were encountered:
No branches or pull requests
I thing we should remove this:
https://github.com/hastic/hastic-server/blob/765cfc7710b2384959bcc11dcac173dd0ab05d68/server/src/services/analytics_service.ts#L207
I found hardcoded port here:
https://github.com/hastic/hastic-server/blob/765cfc7710b2384959bcc11dcac173dd0ab05d68/server/src/services/analytics_service.ts#L79
I find it suspicious that we resolve our promise here:
https://github.com/hastic/hastic-server/blob/765cfc7710b2384959bcc11dcac173dd0ab05d68/server/src/services/analytics_service.ts#L147
we don't guarantee that task will be sent in the same order (because we just place task to the scheduler, but don't know when scheduler will take it):
https://github.com/hastic/hastic-server/blob/765cfc7710b2384959bcc11dcac173dd0ab05d68/server/src/services/analytics_service.ts#L163
.. and we don't await this send function promise
The text was updated successfully, but these errors were encountered: