New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bad constants in analytics_controller.ts #928

Open

jonyrock opened this issue Jul 12, 2020 · 2 comments

Labels

Contributor

jonyrock commented Jul 12, 2020

I don't like that we duplicate this line:
https://github.com/hastic/hastic-server/blob/ae5df8745535bbd1e9a98283587f7f2485cf41a2/server/src/controllers/analytics_controller.ts#L168

maybe we can make a env variable for this?

jonyrock added the refactoring label

Contributor Author

jonyrock commented Jul 12, 2020

Btw. we make it configurable by user in the app?

Contributor Author

jonyrock commented Jul 12, 2020

Also:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment