Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate WhoIs calls to non-blocking async variants #40

Open
JuxhinDB opened this issue Sep 30, 2022 · 0 comments
Open

Migrate WhoIs calls to non-blocking async variants #40

JuxhinDB opened this issue Sep 30, 2022 · 0 comments
Assignees
@JuxhinDB
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@JuxhinDB
Copy link
Collaborator

Currently WhoIs lookup is blocking which causes problems when trying to scale the functionality to hundreds of concurrent requests.

https://github.com/JuxhinDB/twistrs/blob/1f359b5797937115a511847954b5b033cd1bdc22/twistrs/src/enrich.rs#L357-L371

Should take a look at the whois_rust crate and see if it's possible to refactor this to an async call - https://docs.rs/whois-rust/latest/whois_rust/#asynchronous-apis
@JuxhinDB JuxhinDB added enhancement New feature or request good first issue Good for newcomers labels Sep 30, 2022
@JuxhinDB JuxhinDB self-assigned this Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuxhinDB JuxhinDB

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JuxhinDB