Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider deprecating or removing the enrichment module entirely #70

Open
JuxhinDB opened this issue Nov 2, 2023 · 0 comments
Open

Consider deprecating or removing the enrichment module entirely #70

JuxhinDB opened this issue Nov 2, 2023 · 0 comments
Assignees
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@JuxhinDB
Copy link
Collaborator

JuxhinDB commented Nov 2, 2023

Currently the library is a mix between async and non-async modules. The permutation engine is trivial to use and integrate, making it pleasant to work with. The enrichment module however locks into a specified implementation which is (a) inflexible and (b) a pain to maintain.

After some thoughts, it seems that enrichment does not necessarily belong in the library at all, besides perhaps some traits to help library users extend the functionality to their liking.

@JuxhinDB JuxhinDB added help wanted Extra attention is needed question Further information is requested labels Nov 2, 2023
@JuxhinDB JuxhinDB self-assigned this Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant