Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS fixes compiled from various sources #251

Open
Jammmmm opened this issue Nov 3, 2023 · 2 comments
Open

iOS fixes compiled from various sources #251

Jammmmm opened this issue Nov 3, 2023 · 2 comments

Comments

@Jammmmm
Copy link

Jammmmm commented Nov 3, 2023

Hi everyone.

I just want to provide my AppDelegate+notification.m file that fixes most (all?) of the crashing that's in the current iOS build (even 4.0.0). Click the link to check it out.

I've done the following:

I've had this running in production for a few months and I think there's no problems but I would highly recommend that you do your own thorough testing before going into production. Initially the changes were added to the dev version but I recently added them to 4.0.0 and see no issues there either.

And as @igorsantos07 says in his fix, these are basically workarounds made to prevent crashing more than anything else. There's probably better ways to fix each of the above but that would require someone with the time to implement things properly. I'd love to see someone step up and do that :)

Thanks to everyone that contributed!

@gabn88
Copy link

gabn88 commented Nov 3, 2023

@Jammmmm Thanks for this. And also perfect timing (just about to release a new version).

@Jammmmm
Copy link
Author

Jammmmm commented Nov 3, 2023

@Jammmmm Thanks for this. And also perfect timing (just about to release a new version).

No problem, @gabn88! Just make sure you do your own testing. My notification payloads may be different to everyone else's so I might not experience crashing but others still might.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants