Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS Missing call to completionHandler in state UIApplicationStateInactive #252

Closed
scyclops opened this issue Nov 7, 2023 · 0 comments · Fixed by #300
Closed

iOS Missing call to completionHandler in state UIApplicationStateInactive #252

scyclops opened this issue Nov 7, 2023 · 0 comments · Fixed by #300

Comments

@scyclops
Copy link

scyclops commented Nov 7, 2023

In userNotificationCenter:didReceiveNotificationResponse:withCompletionHandler:

case UIApplicationStateInactive:
{
NSLog(@"coldstart");
if([response.actionIdentifier rangeOfString:@"UNNotificationDefaultActionIdentifier"].location == NSNotFound) {
self.launchNotification = userInfo;
}
else {
self.launchNotification = response.notification.request.content.userInfo;
}
self.coldstart = [NSNumber numberWithBool:YES];
break;

completionHandler() is not called in the case above but it is called in the other cases. I'm not sure if this causes any problems but from reading the documentation and looking at other open source code it looks like completionHandler() should always be called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant