You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi! :) We're migrating our Meteor 2 App to Meteor 3.0 right now.
Meteor is a framework built on Node.js which recently had a big rewrite. Before the rewrite it wasn't possible to update past Node version 14.x.
But now with Meteor 3.0, the jump to Node 20 is there. And the same project, which works when run / compiled with node 14, fails when being run with Node 20.
Now we try to get our app to be built on top of the new Meteor 3 / Node 20 branch, but we run into this issue:
The cordova android build fails when the beforeCompile.js hook wants to import from cordova-common:
What I think is strange is that the node_modules folder of the cordova build seems to be too empty:
... is this where the beforeCompile.js should be able to fetch its packages from?
I'm not 100% sure what is going on here, but if anyone has some additional info I'd be happy.
Additional things we've tried:
Importing cordova-common manually in the plugins' package.json 0 file, in dependencies, dev-dependencies, and also in engines/cordovaDependencies, but no dice.
Other, less complex plugins and plugins without this hook seem to work without issues. This is the only plugin where I found this issue.
Expected Behaviour
Cordova will run the beforeCompile.js hook with the package cordova-common (and other packages?) available to be imported.
Actual Behaviour
The build fails.
Reproduce Scenario (including but not limited to)
Sorry, I didn't try to create a reproduction yet.
Steps to Reproduce
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
I'll do a printout when I have more time to investigate, unfortunately I'm short on time right now and it might take a bit. But if there is no progress made I'll get around to this.
The text was updated successfully, but these errors were encountered:
Bug Report
Hi! :) We're migrating our Meteor 2 App to Meteor 3.0 right now.
Meteor is a framework built on Node.js which recently had a big rewrite. Before the rewrite it wasn't possible to update past Node version 14.x.
But now with Meteor 3.0, the jump to Node 20 is there. And the same project, which works when run / compiled with node 14, fails when being run with Node 20.
Now we try to get our app to be built on top of the new Meteor 3 / Node 20 branch, but we run into this issue:
The cordova android build fails when the
beforeCompile.js
hook wants to import fromcordova-common
:What I think is strange is that the
node_modules
folder of the cordova build seems to be too empty:... is this where the
beforeCompile.js
should be able to fetch its packages from?I'm not 100% sure what is going on here, but if anyone has some additional info I'd be happy.
Additional things we've tried:
cordova-common
manually in the plugins'package.json
0 file, independencies
,dev-dependencies
, and also inengines/cordovaDependencies
, but no dice.Other, less complex plugins and plugins without this hook seem to work without issues. This is the only plugin where I found this issue.
Expected Behaviour
Cordova will run the
beforeCompile.js
hook with the packagecordova-common
(and other packages?) available to be imported.Actual Behaviour
The build fails.
Reproduce Scenario (including but not limited to)
Sorry, I didn't try to create a reproduction yet.
Steps to Reproduce
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
(Android) Device Vendor (e.g. Samsung, HTC, Sony...)
cordova info
PrintoutI'll do a printout when I have more time to investigate, unfortunately I'm short on time right now and it might take a bit. But if there is no progress made I'll get around to this.
The text was updated successfully, but these errors were encountered: