Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading setting "gracefulShutdown.enabled" #319

Open
utkukaratas opened this issue Oct 26, 2022 · 0 comments
Open

Misleading setting "gracefulShutdown.enabled" #319

utkukaratas opened this issue Oct 26, 2022 · 0 comments

Comments

@utkukaratas
Copy link
Contributor

utkukaratas commented Oct 26, 2022

One expects setting gracefulShutdown.enabled: false does what it says. But indeed this will just result in not passing a terminationGracePeriodSeconds value at all and that will result in defaulting to whatever is the default terminationGracePeriodSeconds value on k8s. (on my local k8s install that is 60 seconds)

What you need to do for disabling graceful shutdown is gracefulShutdown.maxWaitSeconds: 0

I'd suggest getting rid of gracefulShutdown.enabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant