Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currently unable to pass args to puppeteer launch method. #122

Open
mmoss opened this issue Jun 2, 2020 · 1 comment
Open

Currently unable to pass args to puppeteer launch method. #122

mmoss opened this issue Jun 2, 2020 · 1 comment

Comments

@mmoss
Copy link
Contributor

mmoss commented Jun 2, 2020

Right now the current node-specific implementation is a bit limited, since there's no way to specify arguments to be passed to the launch method for puppeteer here:

defiant.js/index.js

Line 10 in 59f09e5

.launch()

@hbi99
Copy link
Owner

hbi99 commented Jun 4, 2020

Thanks for the feedback...please make a pull request with changes you wish and lets review it together.

@mmoss mmoss mentioned this issue Jun 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hbi99 @mmoss